New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Community, Enterprise, or Professional VS 2017 versions #457

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
2 participants
@JoshuaKGoldberg
Contributor

JoshuaKGoldberg commented Nov 4, 2017

Loops over the potential MSBuild.exe paths for all three, and runs with the first one. If one isn't found it complains.

Fixes #452.

Allowed Community, Enterprise, or Professional VS 2017 versions
Loops over the potential MSBuild.exe paths for all three, and runs with the first one. If one isn't found it complaints.
@Daniel15

This comment has been minimized.

Member

Daniel15 commented Nov 4, 2017

Thanks! I wish there was an environment variable for the path to MSBuild

@Daniel15 Daniel15 merged commit afac9d6 into reactjs:master Nov 4, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@JoshuaKGoldberg JoshuaKGoldberg deleted the JoshuaKGoldberg:dev-build-bat-vs-versions branch Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment