New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey tests #475

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@dustinsoftware
Collaborator

dustinsoftware commented Nov 13, 2017

This is caused by ConfigureMockEnvironment setting up the static
property Environment. Since tests run in parallel, there is a race
between which tests that set up different fake environments, causing
occasional failures. Disabling parallelization fixes the issue, and
tests run so fast that this should be ok.

Fix flakey tests
This is caused by ConfigureMockEnvironment setting up the static
property Environment. Since tests run in parallel, there is a race
between which tests that set up different fake environments, causing
occasional failures. Disabling parallelization fixes the issue, and
tests run so fast that this should be ok.
@Daniel15

This comment has been minimized.

Member

Daniel15 commented Nov 13, 2017

Thanks! I think HtmlHelperExtensions is the only part of ReactJS.NET that doesn't inject dependencies into its constructor (since it consists entirely of static extension methods) and thus relies on some global environment. I wonder if that could be changed/fixed.

@Daniel15 Daniel15 merged commit 5328481 into reactjs:master Nov 13, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment