Removed engine-specific logic from configuration and the engine factory #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core DLL shouldn't have dependencies on specific engine DLLs such as ChakraCore or V8, regardless of .NET version. This change removes `AllowMsieEngine``/allowMsie` from `ReactSiteConfiguration.cs` and any Chakra, V8, and Vroom-specific code from `JavaScriptEngineFactory`. Users would now be required to set the default factory on their own. In a subsequent change, I'd like to add that logic back in with just the JavaScriptEngineSwitcher APIs.
Only in the implementation, not the interface.
Uses MSIE because that was the default already
|
I'll try to take a look at this soon. Does it break the out-of-the-box experience, requiring more manual configuration to get started? |
|
It looks like that wasn't considered in the original pull request.. I'll see if there's a way to preserve the original behavior with this work. |
|
I got close but I don't have time to finish this one. Going to focus on making samples and documentation more accessible for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes merge conflicts in #459 and the error with the msbuild compilation step. Still need to re-test some samples, as they have changed since the PR was initially opened (the build is failing because of broken samples)