New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component name valid caching #529

Merged
merged 2 commits into from Apr 8, 2018

Conversation

Projects
None yet
2 participants
@DaniilSokolyuk
Contributor

DaniilSokolyuk commented Apr 8, 2018

Component name valid caching

DaniilSokolyuk added some commits Apr 8, 2018

@Daniel15

This looks pretty good to me. The only concern I have is that static fields often make unit testing more difficult, as it's tricky to reset the field values. That's likely not really an issue in this particular case, though.

@Daniel15 Daniel15 merged commit 943baec into reactjs:master Apr 8, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment