Skip to content

Add ChakraCore documentation #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2018

Conversation

dustinsoftware
Copy link
Member

@dustinsoftware dustinsoftware commented Jun 3, 2018

Fixes #540

Startup.cs in tutorial code was incorrectly using indentation with spaces, this PR fixes that as well

@Taritsyn
Copy link
Contributor

Taritsyn commented Jun 4, 2018

Hello, Dustin!

It seems to me, that in example for ASP.NET Core should be mentioned about the JavaScriptEngineSwitcher.Extensions.MsDependencyInjection package, because it greatly facilitates registration of JS engines:

using JavaScriptEngineSwitcher.ChakraCore;
using JavaScriptEngineSwitcher.Extensions.MsDependencyInjection;namespace ReactDemo
{
	public class Startup
	{public void ConfigureServices(IServiceCollection services)
		{services.AddJsEngineSwitcher(options =>
				options.DefaultEngineName = ChakraCoreJsEngine.EngineName
			)
				.AddChakraCore()
				;}}
	}
}

In addition, you can give links to the “Registration of JS engines” and “JS Engine Switcher: ChakraCore” sections of JavaScript Engine Switcher documentation.

@dustinsoftware
Copy link
Member Author

Thanks @Taritsyn! I'll update the docs.

@dustinsoftware dustinsoftware merged commit c7c0058 into reactjs:master Jun 10, 2018
@Daniel15
Copy link
Member

Daniel15 commented Jul 1, 2018

Thanks for working on this, @dustinsoftware. I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update server-render documentation
3 participants