React helmet #615
Merged
React helmet #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
reviewed
Oct 27, 2018
| { | ||
| private readonly RenderFunctions m_renderFunctions; | ||
| private readonly IRenderFunctions m_renderFunctions; |
There was a problem hiding this comment.
Nit: Rename this to _renderFunctions. I use an underscore prefix, not m_.
|
Haha thanks, we use m_ at work all the time so that slipped through here..
…On Fri, Oct 26, 2018 at 22:04, Daniel Lo Nigro ***@***.***> wrote:
***@***.**** commented on this pull request.
This looks pretty good to me!
------------------------------
In src/React.Core/RenderFunctionsBase.cs
<#615 (comment)>:
> {
- private readonly RenderFunctions m_renderFunctions;
+ private readonly IRenderFunctions m_renderFunctions;
Nit: Rename this to _renderFunctions. I use an underscore prefix, not m_.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#615 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5hFskBuK1ryCOWwnYZbsDCChwLCfAvks5uo-lMgaJpZM4Xy2Mj>
.
|
|
Interesting! I haven't actually seen m_ used with .NET code, I've only ever
seen it with C++.
…--
Regards,
Daniel Lo Nigro
https://dan.cx/ | Twitter <http://twitter.com/Daniel15> | Facebook
<http://www.facebook.com/daaniel>
On Fri, Oct 26, 2018 at 10:31 PM Dustin Masters <notifications@github.com>
wrote:
Haha thanks, we use m_ at work all the time so that slipped through here..
On Fri, Oct 26, 2018 at 22:04, Daniel Lo Nigro ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> This looks pretty good to me!
> ------------------------------
>
> In src/React.Core/RenderFunctionsBase.cs
> <#615 (comment)>:
>
> > {
> - private readonly RenderFunctions m_renderFunctions;
> + private readonly IRenderFunctions m_renderFunctions;
>
> Nit: Rename this to _renderFunctions. I use an underscore prefix, not m_.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#615 (review)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AA5hFskBuK1ryCOWwnYZbsDCChwLCfAvks5uo-lMgaJpZM4Xy2Mj
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#615 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHdUma4NgnsZj5Qqwv9m0C4p7xAc3ks5uo-_PgaJpZM4Xy2Mj>
.
|
dustinsoftware
force-pushed
the
react-helmet
branch
from
6555f76 to
cec8409
Compare
This is what happens when you contribute to c# projects with c++ naming conventions at work :)
|
Website preview is ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some redundant commits.. another open PR should be merged first, but I can't do that until the github outage is over.