Skip to content

Update to React 0.12.2 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2015
Merged

Conversation

rickbeerendonk
Copy link
Member

Fixes #63

@rickbeerendonk
Copy link
Member Author

Oops, build failure.

@Daniel15
Copy link
Member

I haven't looked at this diff yet as I'm away from my computer, but
JSXTransformer actually has some small patches applied to it to make it
work with the MSIE JavaScript engine (unfortunately I haven't documented
this yet). Basically all instances of string indexing (eg. source[i]) are
replaced with calls to charAt (source.charAt(i)). I've just been doing
this manually so far.

You can diff the old bundled JSXTransformer version with a vanilla version
off the Facebook CDN to see the differences.

Sent from my mobile.
On Jan 10, 2015 1:02 PM, "Rick Beerendonk" notifications@github.com wrote:

Oops, build failure.

Reply to this email directly or view it on GitHub
#66 (comment).

@rickbeerendonk
Copy link
Member Author

@Daniel15 Thank you, I will have a look.

…ng of strings doesn't work, need to use charAt).
@Daniel15
Copy link
Member

Great, thanks! Looks like a fairly small update :)

Daniel15 added a commit that referenced this pull request Jan 11, 2015
@Daniel15 Daniel15 merged commit 362d4f8 into reactjs:master Jan 11, 2015
@rickbeerendonk rickbeerendonk deleted the react-0.12.2 branch January 11, 2015 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to React 0.12.2
2 participants