Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NETCore 3 preview support #791

Merged
merged 14 commits into from Jun 4, 2019
Merged

Add .NETCore 3 preview support #791

merged 14 commits into from Jun 4, 2019

Conversation

@dustinsoftware
Copy link
Member

@dustinsoftware dustinsoftware commented Apr 30, 2019

WIP 馃毃

@dustinsoftware dustinsoftware added this to the 5.0 milestone May 2, 2019
@@ -16,13 +20,13 @@ namespace React.AspNet
/// </summary>
public class AspNetFileSystem : FileSystemBase
{
private readonly IHostingEnvironment _hostingEnv;
private readonly IWebHostEnvironment _hostingEnv;

/// <summary>
/// Initializes a new instance of the <see cref="AspNetFileSystem"/> class.
/// </summary>
/// <param name="hostingEnv">The ASP.NET 5 hosting environment</param>
Copy link
Member

@Daniel15 Daniel15 May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, this still says "ASP.NET 5". We should change that 馃槢

Loading

src/React.Sample.Webpack.CoreMvc/Startup.cs Outdated Show resolved Hide resolved
Loading
Copy link
Member

@Daniel15 Daniel15 left a comment

Seems reasonable to me. Do you think we'd release this before .NET Core 3.0 is out (as a stable release), or wait until the release? I wonder if it's being released at Build this year. 馃憖

Loading

@dustinsoftware
Copy link
Member Author

@dustinsoftware dustinsoftware commented May 3, 2019

My plan was to ship an alpha targeting the .NET Core 3 preview alongside netstandard, and when .NET Core 3 ships we can remove the alpha flag.

Loading

@dustinsoftware
Copy link
Member Author

@dustinsoftware dustinsoftware commented May 6, 2019

Blocked by dotnet/sdk#3146

Loading

@dustinsoftware
Copy link
Member Author

@dustinsoftware dustinsoftware commented May 9, 2019

For whatever reason, I can't get CI to work. This is published as 5.0.0-alpha3. @mbaumanndev

Loading

Azure pipelines works better and faster with .NET Core
@dustinsoftware dustinsoftware marked this pull request as ready for review Jun 4, 2019
@dustinsoftware dustinsoftware merged commit 1805476 into master Jun 4, 2019
1 of 2 checks passed
Loading
@dustinsoftware dustinsoftware deleted the netcore3 branch Jun 4, 2019
@Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Jun 4, 2019

@dustinsoftware Since you deleted the AppVeyor build, the dev build NuGet server (https://reactjs.net/getting-started/download.html#development-builds) won't work any more, as that was coming from AppVeyor. Potentially we can use GitHub's package hosting once that's available. In the interim I can probably set up a self-hosted package server again.

Loading

@dustinsoftware
Copy link
Member Author

@dustinsoftware dustinsoftware commented Jun 4, 2019

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants