Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NETCore 3 preview support #791

Merged
merged 14 commits into from Jun 4, 2019

Conversation

@dustinsoftware
Copy link
Member

commented Apr 30, 2019

WIP 馃毃

@dustinsoftware dustinsoftware referenced this pull request May 2, 2019

Closed

React.NET Breaks on NET Core 3.0 Preview 4 #787

4 of 4 tasks complete

@dustinsoftware dustinsoftware added this to the 5.0 milestone May 2, 2019

@@ -16,13 +20,13 @@ namespace React.AspNet
/// </summary>
public class AspNetFileSystem : FileSystemBase
{
private readonly IHostingEnvironment _hostingEnv;
private readonly IWebHostEnvironment _hostingEnv;

/// <summary>
/// Initializes a new instance of the <see cref="AspNetFileSystem"/> class.
/// </summary>
/// <param name="hostingEnv">The ASP.NET 5 hosting environment</param>

This comment has been minimized.

Copy link
@Daniel15

Daniel15 May 3, 2019

Member

Hah, this still says "ASP.NET 5". We should change that 馃槢

@Daniel15
Copy link
Member

left a comment

Seems reasonable to me. Do you think we'd release this before .NET Core 3.0 is out (as a stable release), or wait until the release? I wonder if it's being released at Build this year. 馃憖

@dustinsoftware

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

My plan was to ship an alpha targeting the .NET Core 3 preview alongside netstandard, and when .NET Core 3 ships we can remove the alpha flag.

@dustinsoftware dustinsoftware force-pushed the netcore3 branch from bae1fe4 to 0ea48d9 May 5, 2019

@dustinsoftware

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

Blocked by dotnet/sdk#3146

@dustinsoftware

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

For whatever reason, I can't get CI to work. This is published as 5.0.0-alpha3. @mbaumanndev

@dustinsoftware dustinsoftware force-pushed the netcore3 branch from ec3c710 to 93fe5b1 Jun 4, 2019

dustinsoftware added some commits Jun 4, 2019

RIP appveyor
Azure pipelines works better and faster with .NET Core

@dustinsoftware dustinsoftware marked this pull request as ready for review Jun 4, 2019

@dustinsoftware dustinsoftware merged commit 1805476 into master Jun 4, 2019

1 of 2 checks passed

reactjs.React.NET Build #20190604.10 failed
Details
deploy/netlify Deploy preview ready!
Details

@dustinsoftware dustinsoftware deleted the netcore3 branch Jun 4, 2019

@Daniel15

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

@dustinsoftware Since you deleted the AppVeyor build, the dev build NuGet server (https://reactjs.net/getting-started/download.html#development-builds) won't work any more, as that was coming from AppVeyor. Potentially we can use GitHub's package hosting once that's available. In the interim I can probably set up a self-hosted package server again.

@dustinsoftware

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.