Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget symbol server #830

Merged
merged 3 commits into from Jun 9, 2019

Conversation

@gunnim
Copy link
Contributor

commented Jun 7, 2019

NuGet finally has a symbol server and it's easy to generate and upload compatible symbols.

This minor change ensures that the symbols get generated.

Per my experience and according to the docs they then get uploaded with the *.nupkg with nuget push.

I did notice issue #467 but was unable to verify that and will assume that functionality is currently broken.

See https://blog.nuget.org/20181116/Improved-debugging-experience-with-the-NuGet-org-symbol-server-and-snupkg.html for more info.

renovate-bot and others added some commits Jun 7, 2019

@Daniel15

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

When I did this for another project, I had to add some stuff to the csproj: https://github.com/Daniel15/fdk-dotnet/blob/master/src/FnProject.Fdk/FnProject.Fdk.csproj#L13-L14

<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>

Does adding -Symbols -SymbolPackageFormat snupkg to the NuGet push command achieve the same thing?

@dustinsoftware

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Symbols should be available with the latest 5.0 alpha nuget package, since it was published from Azure Pipelines (which does not use the build.proj push step). Can you see if symbols are missing on the latest published package?

@gunnim

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

They are indeed missing in the newest alpha build, notice on the right-hand side the download symbols link for fnproject. Missing for react.core
https://www.nuget.org/packages/React.Core/5.0.0-alpha6-dev-20190606-0244
https://www.nuget.org/packages/FnProject.Fdk/

nuget push actually does not work, I confused the way I do it in a project without msbuild.
Verified that snupkg do get created now with this update, and nuget push will detect them and upload since their in the same directory as the nupkg files

@dustinsoftware

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Confirmed via the Azure console that snupkg files are created with this PR. Thanks 👍
image

@dustinsoftware dustinsoftware merged commit df85858 into reactjs:master Jun 9, 2019

2 checks passed

deploy/netlify Deploy preview ready!
Details
reactjs.React.NET Build #20190608.1 succeeded
Details
@dustinsoftware

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

This is published in 5.0.0-alpha7. Haven't verified that the symbols are available on NuGet yet... may have to make one more change and re-publish if they don't show up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.