Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html.ReactWithInit improvements #858

Merged
merged 3 commits into from Jul 5, 2019

Conversation

@dustinsoftware
Copy link
Member

commented Jul 5, 2019

Happy 4th! This addresses a year-old bug report in #543

If you wanted to use output caching, it wasn't really feasible to use Html.ReactWithInit without introducing a render performance penalty, because your script tags had to all be added to the top of the page. This PR waits for the DOMContentLoaded event so that won't be an issue anymore. Calls to Html.React are unaffected.

@dustinsoftware dustinsoftware force-pushed the delayed-init branch from fb2d9d8 to 71d68a7 Jul 5, 2019

@dustinsoftware dustinsoftware merged commit 6d96b4f into master Jul 5, 2019

2 checks passed

deploy/netlify Deploy preview ready!
Details
reactjs.React.NET Build #20190705.2 succeeded
Details

This was referenced Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.