Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Higher Order Components #125

Merged
merged 7 commits into from
Feb 10, 2019
Merged

Translate Higher Order Components #125

merged 7 commits into from
Feb 10, 2019

Conversation

elyalvarado
Copy link
Contributor

No description provided.

@elyalvarado elyalvarado mentioned this pull request Feb 8, 2019
Closed
@elyalvarado
Copy link
Contributor Author

#4

icarlossz
icarlossz suggested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I left you some comments! 👍

content/docs/higher-order-components.md Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@elyalvarado
Copy link
Contributor Author

Thanks @icarlossz for your reviews, I merged some and left comments on the others

@icarlossz
Copy link
Contributor

Thanks! I learned a lot in this PR 😅

@elyalvarado
Copy link
Contributor Author

Hey @RamirezAlex, @carburo will you take a look at this translation? I appreciate your comments from previous translations and I think this one will benefit from an extra pair of eyes.

RamirezAlex
RamirezAlex reviewed Feb 8, 2019
View reviewed changes
Copy link
Contributor

@RamirezAlex RamirezAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work in general, I only that small type and the missing comma :)

content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@elyalvarado
Copy link
Contributor Author

@carburo @alejandronanez I think this is ready for merging

carburo
carburo reviewed Feb 10, 2019
View reviewed changes
Copy link
Member

@carburo carburo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I mostly fixed a few typos and added some missing inverted exclamation and question marks.
Merging...

@carburo carburo merged commit fcf85a3 into reactjs:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamirezAlex RamirezAlex RamirezAlex left review comments

@carburo carburo carburo left review comments

@icarlossz icarlossz icarlossz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elyalvarado @icarlossz @RamirezAlex @carburo