Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Hooks FAQ #151

Merged
merged 12 commits into from
Feb 26, 2019
Merged

Translate Hooks FAQ #151

merged 12 commits into from
Feb 26, 2019

Conversation

caal-15
Copy link
Contributor

@caal-15 caal-15 commented Feb 13, 2019

Translated:

  • Index
  • First Section.

@caal-15 caal-15 mentioned this pull request Feb 13, 2019
Closed
@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for es-reactjs ready!

Built with commit bbc2e9b

https://deploy-preview-151--es-reactjs.netlify.com

sergiodxa
sergiodxa reviewed Feb 20, 2019
View reviewed changes
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
icarlossz
icarlossz suggested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I left you some comments related to accents and typos.

content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
@caal-15
Copy link
Contributor Author

caal-15 commented Feb 20, 2019 •
edited
Loading

  • Componentes

Can you point me at the line where you found the mistake?

icarlossz
icarlossz suggested changes Feb 20, 2019
View reviewed changes
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
alejandronanez
alejandronanez requested changes Feb 21, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @caal-15, welcome to the project, and thanks for your first-time contribution!

This PR is looking really good, thanks for all the effort. I left some comments that are worth addressing before merging this work.

Please, let me know if you have any question or if you need any help!

content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
@alejandronanez alejandronanez changed the title WIP: Translate Hooks FAQ Translate Hooks FAQ Feb 21, 2019
@alejandronanez
Copy link
Member

Hey @caal-15, heads up, there are some merge conflicts that you have to resolve before merging!

@caal-15
Copy link
Contributor Author

caal-15 commented Feb 25, 2019

Hey everyone!, I have fixed the merge conflicts and added @alejandronanez's suggestions, I can add the las section today so we have the whole thing ready for a final review :D

icarlossz
icarlossz suggested changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I left you some comments, thanks.

content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
alejandronanez
alejandronanez requested changes Feb 26, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caal-15, so close!

Left some minor comments that we should be addressed before merging!

Looking great so far, thanks for all your patience and hard work here 💪 !

content/docs/hooks-faq.md Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
alejandronanez
alejandronanez approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @caal-15, thanks for the big effort 🙌 !

@alejandronanez alejandronanez merged commit b6b3a6a into reactjs:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa left review comments

@carburo carburo carburo left review comments

@alejandronanez alejandronanez alejandronanez approved these changes

@icarlossz icarlossz icarlossz approved these changes

Assignees
No one assigned
Labels
changes-requested has-reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caal-15 @alejandronanez @sergiodxa @carburo @icarlossz