translating how to contribute section. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carburo
requested changes
Feb 15, 2019
There was a problem hiding this comment.
Hello! Thank you for your contribution.
Check this before doing a full review.
- It would be better if you could change your lines to match the original. It makes our lives easier when reviewing.
- I noticed you are using "usted" conjugations for the 2nd person singular, you should change it to "tú" as described in the style guide.
- Don't add the nav file. It is already translated.
|
Deploy preview for es-reactjs ready! Built with commit eb1c937 |
|
Deploy preview for es-reactjs ready! Built with commit ef3a998 |
carburo
requested changes
Feb 24, 2019
There was a problem hiding this comment.
Hi! Thank you again for your contribution. I made some suggestions. Many of them related to the use of «usted» (Check our style guide for more information on this matter). Let us know if you need help with this.
|
Hello @maudel. It has been 13 days since the first request for changes. Are you able to check it? Let me know if you don't have enough time. I could help in editing so this can be merged. |
carburo
approved these changes
Mar 3, 2019
|
I applied the changes myself. I think this is good to go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation:
Contributing
@alejandronanez, @carburo, @dmoralesm
Please let me know if everything is looking good.