Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translating how to contribute section. #153

Merged
merged 5 commits into from
Mar 3, 2019
Merged

Conversation

maudel
Copy link
Contributor

@maudel maudel commented Feb 15, 2019

Translation:
Contributing

  • How to Contribute

@alejandronanez, @carburo, @dmoralesm
Please let me know if everything is looking good.

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.
Check this before doing a full review.

  • It would be better if you could change your lines to match the original. It makes our lives easier when reviewing.
  • I noticed you are using "usted" conjugations for the 2nd person singular, you should change it to "tú" as described in the style guide.
  • Don't add the nav file. It is already translated.

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for es-reactjs ready!

Built with commit eb1c937

https://deploy-preview-153--es-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for es-reactjs ready!

Built with commit ef3a998

https://deploy-preview-153--es-reactjs.netlify.com

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you again for your contribution. I made some suggestions. Many of them related to the use of «usted» (Check our style guide for more information on this matter). Let us know if you need help with this.

content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@carburo
Copy link
Member

carburo commented Feb 28, 2019

Hello @maudel. It has been 13 days since the first request for changes. Are you able to check it? Let me know if you don't have enough time. I could help in editing so this can be merged.

@carburo
Copy link
Member

carburo commented Mar 3, 2019

I applied the changes myself. I think this is good to go. Thanks!

@carburo carburo merged commit 91490a6 into reactjs:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants