Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Translate Testing Overview doc to Spanish #275

Merged
merged 13 commits into from
Aug 23, 2019

Conversation

rootlinux2
Copy link
Contributor

There are some terms like ["TradeOff", "How much to mock", "mocking"] was difficult to me find a way to explain in Spanish, any feedback will be welcome.

@netlify
Copy link

netlify bot commented Aug 21, 2019

Deploy preview for es-reactjs ready!

Built with commit d88a632

https://deploy-preview-275--es-reactjs.netlify.com

@Darking360 Darking360 self-requested a review August 22, 2019 17:24
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @rootlinux2 muchas gracias por acercarte a la documentación, y muy buen PR 🚀

Agregué unas cuantas sugerencias, unos typos pequeños, y una observación para que mantengas los mismos números de línea que el contenido original, asi evitamos errores con git en el futuro, en cuanto agregues esto le echo otra mirada y lo agregamos 💯

Me comentas que tal 👍

content/docs/testing.md Outdated Show resolved Hide resolved

This documentation section focuses on testing strategies for the first case. While full end-to-end tests can be very useful to prevent regressions to important workflows, such tests are not concerned with React components in particular, and are out of scope of this section.
* **Renderizado del árbol de componentes** en un entorno de prueba simplificado y comprobación de sus salidas.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Renderizado del árbol de componentes** en un entorno de prueba simplificado y comprobación de sus salidas.
* **Renderizado del árbol de componentes** en un entorno de prueba simplificado y comprobando de sus salidas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En tu sugerencia despues del cambio de "comprobación" por comprobando, se debe retirar el "de" que le sigue.
Resultado seria:

  • Renderizado del árbol de componentes en un entorno de prueba simplificado y comprobando sus salidas.

content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
rootlinux2 and others added 12 commits August 22, 2019 16:13
Remove unnecessary space.

Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Remove unnecessary space.

Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Grammatically corrections

Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
Co-Authored-By: Miguel Alejandro Bolivar Portilla <MBolivar360@gmail.com>
@Darking360
Copy link
Collaborator

Darking360 commented Aug 23, 2019

Hey @rootlinux2 perfecto, todo bien, solamente arregle unos enlaces que estaban mal 💪 oficialmente bienvenido y nuevamente gracias por aportar a la documentación 🚀

Si deseas seguir contribuyendo, aun tenemos ciertas paginas sin traducir aqui:

Cualquier cosa nos comentas 💯

@Darking360 Darking360 merged commit 343f10e into reactjs:master Aug 23, 2019
@carburo carburo mentioned this pull request Oct 5, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants