Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated till line 50 #211

Merged
merged 26 commits into from Nov 1, 2022
Merged

translated till line 50 #211

merged 26 commits into from Nov 1, 2022

Conversation

Akshat2Jain
Copy link
Contributor

Hey, @arshadkazmi42 I have translated till line 50. Plz, review it so that I can keep continuing the translation.

Hey, @arshadkazmi42 I have translated till line 50. Plz, review it so that I can keep continuing the translation.
@arshadkazmi42
Copy link
Member

Thank you @Akshat2Jain for working on this.

But we follow the process of translating the whole page and then reviewing it in parts. We faced issues before when we were trying to do translations in part.

So I would suggest, please work on translating the whole file then we can start with the review.

@Akshat2Jain
Copy link
Contributor Author

ok, @arshadkazmi42 sir

translated till line 440 in hindi
@Akshat2Jain
Copy link
Contributor Author

Hey @arshadkazmi42 sir, I have made the changes plz review them so that we can move forward

@Akshat2Jain
Copy link
Contributor Author

I have fixed the changes. Plz review them

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.

Add the review to the test of the file.

Once these are fixed, we can get this merged.

beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/pages/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
@Akshat2Jain
Copy link
Contributor Author

Hey @arshadkazmi42 sir, I have fixed the changes. Please, review them so that we can merge this.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 🚀

Thank you for working on all the fixes.

Lets get this merged 🎉

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/updating-objects-in-state 65.69 KB (🟡 +3.21 KB) 160.92 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@arshadkazmi42 arshadkazmi42 merged commit c040c17 into reactjs:main Nov 1, 2022
@Akshat2Jain
Copy link
Contributor Author

Thanks For merging the Pr.
Thank You @arshadkazmi42 Sir for guiding me. It's an achievement for me to contribute to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants