Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate FAQ > Component State #102

Merged
merged 18 commits into from May 29, 2019
Merged

Translate FAQ > Component State #102

merged 18 commits into from May 29, 2019

Conversation

ejolie
Copy link
Contributor

@ejolie ejolie commented Apr 22, 2019 •
edited

@netlify
Copy link

netlify bot commented Apr 22, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 12fd490

https://deploy-preview-102--ko-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Apr 22, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit a9f18a8

https://deploy-preview-102--ko-reactjs-org.netlify.com

@tesseralis tesseralis mentioned this pull request Apr 22, 2019
Closed
98 tasks
@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Apr 22, 2019
hg-pyun
hg-pyun requested changes Apr 23, 2019
View reviewed changes
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
@hg-pyun hg-pyun added needs +1 approval needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Apr 23, 2019
@ejolie
Copy link
Contributor Author

ejolie commented Apr 24, 2019

Translation glossary에 따르면 'chapter'은 '장'으로 되어있는데,
'section'은 그냥 '섹션'으로 번역하면 될까요? 🤔

알맞은 한국어 단어를 찾지 못해 '장'으로 번역했었는데
'섹션'이 맞는 것 같아 문의드립니다!

@hg-pyun
Copy link
Member

hg-pyun commented Apr 24, 2019

@taehwanno @simsim0709 @ejolie

section은 어떻게 번역하면 좋을까요?

@hg-pyun hg-pyun removed the needs author response Changes requested needing author's input label Apr 24, 2019
hg-pyun
hg-pyun previously approved these changes Apr 30, 2019
View reviewed changes
@hg-pyun
Copy link
Member

hg-pyun commented Apr 30, 2019

@ejolie section은 사전을 찾아보니 절로 해주시면 될 것 같습니다.

gnujoow
gnujoow previously approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gnujoow gnujoow added ready to merge push the merge button :) and removed needs +1 approval labels May 3, 2019
hg-pyun
hg-pyun reviewed May 3, 2019
View reviewed changes
content/docs/faq-state.md Outdated Show resolved Hide resolved
@hg-pyun hg-pyun added needs author response Changes requested needing author's input and removed ready to merge push the merge button :) labels May 3, 2019
@ejolie ejolie dismissed stale reviews from gnujoow and hg-pyun via ec3241e May 3, 2019 10:28
hg-pyun
hg-pyun previously approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve 합니다. 고생하셨습니다 :)

@hg-pyun
Copy link
Member

hg-pyun commented May 21, 2019

@taehwanno @gnujoow Approve 한분 더 부탁드립니다.

@hg-pyun hg-pyun added needs +1 approval ready to merge push the merge button :) and removed needs author response Changes requested needing author's input labels May 21, 2019
@simsim0709 simsim0709 self-requested a review May 22, 2019 04:08
@simsim0709 simsim0709 added needs author response Changes requested needing author's input and removed ready to merge push the merge button :) labels May 22, 2019
hg-pyun and others added 3 commits May 24, 2019 10:50
@hg-pyun
Merge branch 'master' into ejolie
3488c35
@hg-pyun
Merge branch 'master' into ejolie
5111677
@ejolie
Resolve review
a9f18a8 
 '사용하는 게 좋습니다.' -> '아마 필요할 수도 있습니다.'
@taehwanno taehwanno added needs +1 approval and removed needs author response Changes requested needing author's input labels May 28, 2019
taehwanno
taehwanno approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

simsim0709
simsim0709 approved these changes May 29, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다~ 👍

@simsim0709 simsim0709 merged commit 2e81dca into reactjs:master May 29, 2019
@ejolie ejolie deleted the ejolie branch October 21, 2019 02:07
@ejolie ejolie restored the ejolie branch October 21, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taehwanno taehwanno taehwanno approved these changes

@simsim0709 simsim0709 simsim0709 approved these changes

@hg-pyun hg-pyun hg-pyun left review comments

@gnujoow gnujoow gnujoow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ejolie @hg-pyun @taehwanno @simsim0709 @gnujoow