Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Testing overview page #179

Merged
merged 8 commits into from Nov 14, 2019
Merged

Translate Testing overview page #179

merged 8 commits into from Nov 14, 2019

Conversation

koDaegon
Copy link
Contributor

@koDaegon koDaegon commented Oct 31, 2019

Progress

@netlify
Copy link

netlify bot commented Oct 31, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 489ca1b

https://deploy-preview-179--ko-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Oct 31, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit fae2125

https://deploy-preview-179--ko-reactjs-org.netlify.com

content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
content/docs/testing.md Outdated Show resolved Hide resolved
@hg-pyun hg-pyun added needs author response Changes requested needing author's input needs review Needs review A pull request ready to be reviewed labels Nov 3, 2019
@taehwanno taehwanno removed the needs review Needs review A pull request ready to be reviewed label Nov 3, 2019
@koDaegon
Copy link
Contributor Author

koDaegon commented Nov 5, 2019

리뷰해 주신 부분 참고하여 업데이트 하였습니다.

@taehwanno taehwanno added needs +1 approval and removed needs author response Changes requested needing author's input labels Nov 5, 2019
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnujoow gnujoow added ready to merge push the merge button :) and removed needs +1 approval labels Nov 12, 2019
@gnujoow
Copy link
Member

gnujoow commented Nov 14, 2019

@taehwanno 👍

@hg-pyun
Copy link
Member

hg-pyun commented Nov 14, 2019

Merge 하겠습니다 :) 고생하셨습니다.

@hg-pyun hg-pyun merged commit 9365ffe into reactjs:master Nov 14, 2019
@tesseralis tesseralis mentioned this pull request Nov 21, 2019
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge push the merge button :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants