Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web-components.md due to translation errors #324

Merged
merged 1 commit into from Jun 25, 2021
Merged

Update web-components.md due to translation errors #324

merged 1 commit into from Jun 25, 2021

Conversation

ainochi-kor
Copy link
Contributor

@ainochi-kor ainochi-kor commented Jun 21, 2021 •
edited

@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for ko-reactjs-org ready!

🔨 Explore the source changes: d0f0842

🔍 Inspect the deploy log: https://app.netlify.com/sites/ko-reactjs-org/deploys/60d029aadf24fa0008c70ab8

😎 Browse the preview: https://deploy-preview-324--ko-reactjs-org.netlify.app

@ainochi-kor
Copy link
Contributor Author

ainochi-kor commented Jun 21, 2021 •
edited

"react에서 웹 컴포넌트를 사용할지,
웹 컴포넌트를 react에서 사용할지, "

번역기에 돌려보면,

"Whether to use web components in react or not.
Whether to use Web components in react or not."

"react에서 웹 컴포넌트를 사용할지" is mean == "웹 컴포넌트를 react에서 사용할지" is mean

번역에 대한 변경이 필요합니다.
Changes to the translation are needed.

@ainochi-kor ainochi-kor changed the title Update web-components.md Update web-components.md due to translation errors Jun 21, 2021
hg-pyun
hg-pyun approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여 감사합니다!

@hg-pyun hg-pyun added the ready to merge push the merge button :) label Jun 25, 2021
@hg-pyun hg-pyun merged commit 17aaf24 into reactjs:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
ready to merge push the merge button :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ainochi-kor @hg-pyun