Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 알 수 없는 문자 제거 #491

Merged
merged 2 commits into from Jul 29, 2022
Merged

fix: 알 수 없는 문자 제거 #491

merged 2 commits into from Jul 29, 2022

Conversation

parkgang
Copy link
Contributor

@parkgang parkgang commented Jul 26, 2022

Fix

알 수 없는 문자가 포함되어 수정하였습니다.

title before after
Hook image image
Children image image
Suspense image image

ps. check-all scripts를 실행하니 2022-03-08-react-18-upgrade-guide.md 내용에 id 가 추가되어있지 않아 변경사항이 발생했는데 문제는 문장 끝에 쌍점(:) 으로 끝나는 것이 있어 commit 하지 못하였습니다. 실제 origin 을 보니까 : 으로 끝나더군요 issue 를 보니 React@v18 이 한글 번역되면서 자연스럽게 해결될 것 같아 해당 부분은 그대로 놔두었습니다.

Progress

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parkgang
Copy link
Contributor Author

@hg-pyun 승인 대기 중인 3개의 워크플로가 있다고 하는데 이 부분은 따로 요청드려야 하나요?

@gnujoow gnujoow merged commit e3edd30 into reactjs:main Jul 29, 2022
@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants