Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate docs navigation #84

Merged
merged 4 commits into from Apr 7, 2019
Merged

Translate docs navigation #84

merged 4 commits into from Apr 7, 2019

Conversation

taehwanno
Copy link
Member

@taehwanno taehwanno commented Mar 29, 2019

I translated docs navigation :)

Progress

@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Mar 29, 2019
@tesseralis tesseralis mentioned this pull request Mar 29, 2019
98 tasks
@netlify
Copy link

netlify bot commented Mar 29, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 6c9bd36

https://deploy-preview-84--ko-reactjs-org.netlify.com

- id: context
title: Context
- id: error-boundaries
title: Error Boundaries
title: 에러 경계
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Boundaries 번역이 필요할까요? React에서 사용하는 고유 단어라고 생각하면 번역 안 하는 게 낫지 않을까 해서요. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇죠..? ㅎ.ㅎ 이거 고민 좀 했었는데 단수형으로 Error Boundary로 바꿀게요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsim0709 simsim0709 added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Apr 3, 2019
@taehwanno taehwanno added needs +1 approval and removed needs author response Changes requested needing author's input labels Apr 4, 2019
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun hg-pyun merged commit 65971f6 into master Apr 7, 2019
@hg-pyun hg-pyun deleted the translate-docs-nav branch April 7, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants