Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Redraw and nextProps #22

@bultas

Description

@bultas

In my opinion, should be in Core.js/componentWillReceiveProps nextProps.redraw instead of this.props.redraw,
With nextProps.redraw you enable to choose how user want draw the chart in next update cycle (redraw:false with new metrics or redraw:true with new labels,..).
But with this.props.redraw you can affect only second update cycle, which is not so flexible and you can not redraw chart instantly when you need it.

Is there some point why it has to be this.props.redraw or can I create pull request?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions