fix(react-docgen): add ObjectMethod support to resolveName #1036
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d27b6bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for react-docgen ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Extend the resolveName function in getMemberExpressionValuePath.ts to handle ObjectMethod nodes, preventing the error below from being thrown during AST resolution of member expressions within object methods. TypeError: Attempted to resolveName for an unsupported path. resolveName does not accept ObjectMethod. Fix reactjs#902
danez
reviewed
Oct 8, 2025
danez
reviewed
Oct 8, 2025
packages/react-docgen/src/utils/getMemberExpressionValuePath.ts
Outdated
Show resolved
Hide resolved
|
I did some more testing and turns out we simply have to ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the resolveName function in
getMemberExpressionValuePath.tsto handleObjectMethodnodes, preventing the error below from being thrown during AST resolution of member expressions within object methods.Fix #902
Since I faced the exact same error as the one reported on the issue above in our project, I managed to pin point the place where the error was happening and created a minimal test that reproduce the scenario.