Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resolveComponentDefinition into findComponentDefinition #719

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

danez
Copy link
Collaborator

@danez danez commented Jan 3, 2023

Refactored resolveComponentDefinition utility.

  • Renamed to findComponentDefinition
  • Removed named export isComponentDefinition
  • The utility now does a lot more than previously, check out the commit to see
    the changes in detail.

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2023

🦋 Changeset detected

Latest commit: cee6c70

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@react-docgen-internal/benchmark" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@react-docgen-internal/playground" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for react-docgen ready!

Name Link
🔨 Latest commit cee6c70
🔍 Latest deploy log https://app.netlify.com/sites/react-docgen/deploys/63b4893416ea5b000adf38c9
😎 Deploy Preview https://deploy-preview-719--react-docgen.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danez danez enabled auto-merge (squash) January 3, 2023 20:01
@danez danez merged commit d7a39af into main Jan 3, 2023
@danez danez deleted the resolv branch January 3, 2023 20:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant