Check for import declaration type when getting default values, resolves #63 #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common pattern in libraries is to set a default prop value as an imported component, for eg. a transition component for a dialog.
#63 has an example + a workaround (not the most elegant however, involves using a functional component to return the default component).
Right now,
react-docgen
throws an error on components implementing this pattern asImportDefaultDeclaration
is not a printable type.This PR adds a conditional after the
resolveToValue(path)
call ingetDefaultValue(path)
to check if the node is an import declaration. If so, it returns the.name
property of the original node (so the function/component name).