New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for SVG attributes conversion #136

Merged
merged 4 commits into from Aug 13, 2017

Conversation

Projects
None yet
3 participants
@tsuyoshiwada
Contributor

tsuyoshiwada commented Jun 20, 2017

Hi, Thank you for useful library 馃槂

I wanted to convert the attributes of SVG like #135.
However, when I actually convert it I got the following output.

- Actual: fill-rule, stroke-width
+ Expected: fillRule, strokeWidth

So we added SVGDOMPropertyConfig as an attribute mapping target as well asHTMLDOMPropertyConfig.

Related issues

@ritz078

This comment has been minimized.

Show comment
Hide comment
@ritz078

ritz078 Aug 9, 2017

Any chance of this getting merged soon ?

ritz078 commented Aug 9, 2017

Any chance of this getting merged soon ?

@tsuyoshiwada

This comment has been minimized.

Show comment
Hide comment
@tsuyoshiwada

tsuyoshiwada Aug 10, 2017

Contributor

Hi @ritz078 .

If you are in a hurry, htmltojsx that corresponds to SVG is released in Scoped Package, so please try using it 馃槂

https://github.com/tsuyoshiwada/htmltojsx

Contributor

tsuyoshiwada commented Aug 10, 2017

Hi @ritz078 .

If you are in a hurry, htmltojsx that corresponds to SVG is released in Scoped Package, so please try using it 馃槂

https://github.com/tsuyoshiwada/htmltojsx

@Daniel15

This comment has been minimized.

Show comment
Hide comment
@Daniel15

Daniel15 Aug 10, 2017

Member

Sorry, I completely missed this... I'll take a look soon!

Member

Daniel15 commented Aug 10, 2017

Sorry, I completely missed this... I'll take a look soon!

@tsuyoshiwada

This comment has been minimized.

Show comment
Hide comment
@tsuyoshiwada

tsuyoshiwada Aug 10, 2017

Contributor

Hi @Daniel15, Thanks !

Contributor

tsuyoshiwada commented Aug 10, 2017

Hi @Daniel15, Thanks !

@ritz078

This comment has been minimized.

Show comment
Hide comment
@ritz078

ritz078 commented Aug 10, 2017

Thanks @tsuyoshiwada . FYI I am using it on https://transform.now.sh/html-to-jsx

}
output.push(this.toJSXKey(key) + ': ' + this.toJSXValue(this.styles[key]));
}
eachObj(this.styles, function(key, value) {

This comment has been minimized.

@Daniel15

Daniel15 Aug 13, 2017

Member

What's the purpose of this change?

@Daniel15

Daniel15 Aug 13, 2017

Member

What's the purpose of this change?

This comment has been minimized.

@tsuyoshiwada

tsuyoshiwada Aug 14, 2017

Contributor

We have refactored the iteration of the object using the newly created eachObj helper.
I'm sorry I made a confusing change... 馃槩

@tsuyoshiwada

tsuyoshiwada Aug 14, 2017

Contributor

We have refactored the iteration of the object using the newly created eachObj helper.
I'm sorry I made a confusing change... 馃槩

This comment has been minimized.

@Daniel15

Daniel15 Aug 14, 2017

Member

It's totally fine, don't worry @tsuyoshiwada 馃槃 I was just wondering about why we couldn't just continue to use a regular for loop here.

@Daniel15

Daniel15 Aug 14, 2017

Member

It's totally fine, don't worry @tsuyoshiwada 馃槃 I was just wondering about why we couldn't just continue to use a regular for loop here.

This comment has been minimized.

@tsuyoshiwada

tsuyoshiwada Aug 14, 2017

Contributor

Thank you! It was worried whether it became a meddle, but I am relieved 馃槂

@tsuyoshiwada

tsuyoshiwada Aug 14, 2017

Contributor

Thank you! It was worried whether it became a meddle, but I am relieved 馃槂

@Daniel15 Daniel15 merged commit fab1517 into reactjs:master Aug 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Daniel15

This comment has been minimized.

Show comment
Hide comment
@Daniel15

Daniel15 Sep 5, 2017

Member

Released as 0.3.0 馃槂

Member

Daniel15 commented Sep 5, 2017

Released as 0.3.0 馃槂

@tsuyoshiwada

This comment has been minimized.

Show comment
Hide comment
@tsuyoshiwada

tsuyoshiwada Sep 5, 2017

Contributor

Hi @Daniel15, Thank you 馃槃 I checked that I was working.

Contributor

tsuyoshiwada commented Sep 5, 2017

Hi @Daniel15, Thank you 馃槃 I checked that I was working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment