Skip to content

Conversation

alansouzati
Copy link
Contributor

Hi guys,

This PR aims to switch from jsdom to jsdom-no-contextify. jsdom version 4.4.x does not support Node 10, and jsdom 3.1.x has dependencies with contextify. Contextify has native build that requires Python.

As a result, I believe it makes sense to move to jsdom-no-contextify. I tried running the build with react-magic and everything seems to be working fine.

Alan

@alansouzati
Copy link
Contributor Author

Hi guys, I guess everything is looking ok here. Would appreciate any feedback as our team is looking for supporting Node 10. 👍

@Daniel15
Copy link
Member

Daniel15 commented Jul 4, 2015

I'm on vacation from 2nd July until 12th July with limited internet access.
I'll take a look at this once I'm back.

Sent from my mobile.
On Jul 2, 2015 8:11 AM, "Alan Souza" notifications@github.com wrote:

Hi guys, I guess everything is looking ok here. Would appreciate any
feedback as our team is looking for supporting Node 10. [image: 👍]


Reply to this email directly or view it on GitHub
#29 (comment).

@alansouzati
Copy link
Contributor Author

Hey @Daniel15 any news here?

Daniel15 added a commit that referenced this pull request Aug 3, 2015
@Daniel15 Daniel15 merged commit 2dc2040 into reactjs:master Aug 3, 2015
@Daniel15
Copy link
Member

Daniel15 commented Aug 3, 2015

Sorry for the delay!

@alansouzati
Copy link
Contributor Author

Great news @Daniel15 ! Thanks for working on that. Could you please release a new version on NPM that includes this fix? 👍

@Daniel15
Copy link
Member

Daniel15 commented Aug 6, 2015

Oops, I thought I did that when I merged this, but I must have gotten distracted 😄 Pushed 0.2.3 now, thanks for the reminder.

@alansouzati
Copy link
Contributor Author

No problem at all. thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants