Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace string refs with callback refs #289

Closed
claydiffrient opened this issue Dec 28, 2016 · 0 comments
Closed

Replace string refs with callback refs #289

claydiffrient opened this issue Dec 28, 2016 · 0 comments
Assignees
@claydiffrient
Labels
enhancement
Milestone
2.0.0

Comments

@claydiffrient
Copy link
Contributor

There are several places we use string refs in ModalPortal. These should be replaced with callback refs.
@claydiffrient claydiffrient added this to the 2.0.0 milestone Dec 28, 2016
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make lib/components pass linter
e97918e 
This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes #289
@claydiffrient claydiffrient self-assigned this Dec 31, 2016
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make lib/components pass linter
0b4ab7d 
This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes #289
closes #286
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make lib/components pass linter
99b45d1 
This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes #289
closes #286
diasbruno pushed a commit to diasbruno/react-modal that referenced this issue Jun 13, 2017
@claydiffrient @diasbruno
Add Linting (reactjs#293)
27ec79b 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes reactjs#289
closes reactjs#286

* Make travis run the lint task as well as specs

closes reactjs#284
diasbruno pushed a commit to diasbruno/react-modal that referenced this issue Jun 15, 2017
@claydiffrient @diasbruno
Add Linting (reactjs#293)
7bd3063 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes reactjs#289
closes reactjs#286

* Make travis run the lint task as well as specs

closes reactjs#284
diasbruno pushed a commit to diasbruno/react-modal that referenced this issue Jun 15, 2017
@claydiffrient @diasbruno
Add Linting (reactjs#293)
96668ba 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes reactjs#289
closes reactjs#286

* Make travis run the lint task as well as specs

closes reactjs#284
diasbruno pushed a commit that referenced this issue Jun 15, 2017
@claydiffrient @diasbruno
Add Linting (#293)
1c326a1 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes #289
closes #286

* Make travis run the lint task as well as specs

closes #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claydiffrient claydiffrient

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@claydiffrient