Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN installation in documentation #889

Closed
EliseyMartynov opened this issue Jun 18, 2021 · 1 comment
Closed

CDN installation in documentation #889

EliseyMartynov opened this issue Jun 18, 2021 · 1 comment

Comments

@EliseyMartynov
Copy link
Contributor

EliseyMartynov commented Jun 18, 2021

Summary: Could you please notice cdn install in docs because I've to check <ReactModal> tag in your example :) But services like cdnjs.com have your cdn that's very cool (link to cdn).

Link to example of issue:

http://reactcommunity.org/react-modal/#installation

My suggestion is something like:

  • Add script tag after React CDN scripts: <script src="https://cdnjs.cloudflare.com/ajax/libs/react-modal/3.14.3/react-modal.min.js" integrity="sha512-MY2jfK3DBnVzdS2V8MXo5lRtr0mNRroUI9hoLVv2/yL3vrJTam3VzASuKQ96fLEpyYIT4a8o7YgtUs5lPjiLVQ==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
  • Use tag inside your React CDN APP
EliseyMartynov added a commit to EliseyMartynov/react-modal that referenced this issue Jun 18, 2021
Noticing cdn install in docs because I'd to check <ReactModal> tag in docs example but didn't see this in Installation section :)
diasbruno pushed a commit that referenced this issue Jun 18, 2021
Noticing cdn install in docs because I'd to check <ReactModal> tag in docs example but didn't see this in Installation section :)
@EliseyMartynov
Copy link
Contributor Author

Solved in PR #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant