Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] upgrade React devDeps to 15.6 #421

Merged
merged 2 commits into from
Jun 19, 2017

Conversation

fuller
Copy link
Contributor

@fuller fuller commented Jun 16, 2017

Fixes #[issue number].

Changes proposed:

  • Upgrade React to the latest version
  • Remove the deprecated react-addons-test-utils in favor of accessing from react-dom/test-utils

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

coveralls commented Jun 16, 2017

Coverage Status

Coverage remained the same at 84.821% when pulling dee03b7 on ajfuller:upgrade/react-dep into 88d2ae1 on reactjs:master.

Copy link
Collaborator

@diasbruno diasbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has some changes that are out of the scope, but refactoring is always a good thing.

Some of the changes makes lines longer. You can move some of the expect(CHECK) to a variable, like:

const check = ...;
expect(check).toBe(...);

jsx syntax is better to read if they have their own line, and, sometimes, wrapped with (), so any editor can indent better/correct. Example:

ReactDOM.render((
  <Modal isOpen appElement={el} />
), node);

specs/helper.js Outdated
(element, opts) =>
eventCtor(
element,
Object.assign(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we can use ... operator instead of Object.assign.

specs/helper.js Outdated
key: key,
keyCode: code,
which: code
},
Copy link
Collaborator

@diasbruno diasbruno Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we can use { key, keyCode: code, which: code }.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...or change the code on the arguments to keyCode.
{ key, keyCode, which: keyCode }

@diasbruno
Copy link
Collaborator

diasbruno commented Jun 18, 2017

@ajfuller I'll finish to update the changelog and I'll merge this PR, then we can release a version.

@fuller
Copy link
Contributor Author

fuller commented Jun 19, 2017

Sorry I have prettier enabled in Atom so it made a few more changes than I had expected. I'll make the requested changes.

@fuller
Copy link
Contributor Author

fuller commented Jun 19, 2017

@diasbruno I've cleaned this up so it's just the upgrade related changes. Other refactoring can be in a separate PR 😸.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.821% when pulling c8b5fcd on ajfuller:upgrade/react-dep into 8480042 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.821% when pulling c8b5fcd on ajfuller:upgrade/react-dep into 8480042 on reactjs:master.

@diasbruno diasbruno merged commit 6c780ae into reactjs:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants