[fixed] check if element exists before focusing in scopeTab helper #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diasbruno
reviewed
Sep 26, 2018
src/helpers/scopeTab.js
Outdated
| @@ -62,6 +62,10 @@ export default function scopeTab(node, event) { | |||
| x += shiftKey ? -1 : 1; | |||
| } | |||
|
|
|||
| // If the tabbable element does not exist, | |||
| // let the browser control the focus | |||
| if (typeof tabbable[x] === "undefined") return; | |||
There was a problem hiding this comment.
Maybe, we actually need to focus the first element in this case, otherwise I suspect it can miss radios inputs.
There was a problem hiding this comment.
Updated to focus head/tail based on shiftKey
diasbruno
approved these changes
Sep 26, 2018
|
Thanks you, @DarudeGarystorm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #687
Changes proposed:
Acceptance Checklist:
CONTRIBUTING.md.