Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#664): partial - allow empty classNames for body and portal #698

Closed
wants to merge 1 commit into from
Closed

fix(#664): partial - allow empty classNames for body and portal #698

wants to merge 1 commit into from

Conversation

fortwo
Copy link

@fortwo fortwo commented Oct 10, 2018

Fixes #[issue number].

Changes proposed:

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.697% when pulling 134c6f9 on one89:master into 1b561fc on reactjs:master.

@diasbruno
Copy link
Collaborator

Hi @one89. Looks good. I'll check it later. If you can update the description with the correct issue this PR will fix, it would be great.

@diasbruno
Copy link
Collaborator

@one89 Can you please include a test case to check the case where bodyOpenClassName is null?

@fortwo fortwo closed this by deleting the head repository Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fortwo @coveralls @diasbruno