[fixed] Allow ReactDOM.createPortal to be mocked in tests #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @devrelm, I'll have a look on all PRs this weekend. Thanks! |
|
Thanks, @devrelm. Good job! |
programmer4web
pushed a commit
to programmer4web/react-modal
that referenced
this pull request
Oct 5, 2020
Fixes reactjs#553 - PR reactjs#701 * Allow ReactDOM.createPortal to be mocked in tests (9cd0891) * add testability tests (6a67946) * linting (f29e7b0) * more linting (5992f97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553
See the related comment.
Changes proposed:
createPortalmethod-resolution inside a method so that it can be determined at the time that it is needed. This allows developers to mock outReactDOM.createPortalinside tests, which can be needed for various reasons including react-test-renderer not supporting portals.Upgrade Path (for changed or removed APIs):
N/A
Acceptance Checklist:
CONTRIBUTING.md.