Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] isNested prop #707

Closed
wants to merge 3 commits into from
Closed

[added] isNested prop #707

wants to merge 3 commits into from

Conversation

Jarch09
Copy link

@Jarch09 Jarch09 commented Oct 25, 2018

Changes proposed:

  • adds isNested: bool (optional) prop, which gives you the option of not removing the modal backdrop.

Why? This enables Russian doll nesting, so you can have multiple modals open on top of each other.

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 86.758% when pulling 4c17fc4 on Jarch09:add-nesting into 1b561fc on reactjs:master.

@diasbruno
Copy link
Collaborator

Hi @Jarch09, I'll have a look on all PRs this weekend. Thanks!

@Jarch09
Copy link
Author

Jarch09 commented Oct 31, 2018

Hey you have a chance to check this out?

@diasbruno
Copy link
Collaborator

@Jarch09 Yep. This looks good. I'm thinking of push this to v4.

@willsmanley
Copy link

So is this going to be pulled at any point?

Does this change only remove the background effect or does it also affect modal stacking order?

@Jarch09 Jarch09 closed this by deleting the head repository Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants