Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a lint task that uses the rackt eslint config #90

Closed
wants to merge 1 commit into from

Conversation

pwmckenna
Copy link

while the style will probably change as more repos are updated (hence the overrides for this repo), this PR introduces eslint and uses the rackt eslint config). I didn't want this to change any code, so rules that did not pass were overridden/disabled to just enforce the style that already exists.

Here is the repo for the base config being enforced: https://github.com/rackt/eslint-config-rackt

The original discussion around a centralized eslint config can be found here: remix-run/history#112

@pwmckenna pwmckenna force-pushed the lint-task branch 3 times, most recently from cab874e to 039cf3d Compare October 27, 2015 02:28
@diasbruno
Copy link
Collaborator

Hi, @pwmckenna. This is great. +1

@claydiffrient
Copy link
Contributor

@pwmckenna @diasbruno I'm a bit skeptical on this one. eslint-config-rackt doesn't seem to have been migrated over to the reactjs organization. I'm a bit hesitant to rely on something that is npm only at the moment.

@diasbruno
Copy link
Collaborator

Yeah, I understand. Maybe the simple eslint would do the job.

@claydiffrient
Copy link
Contributor

I'm going to go ahead and close this, opening a new issue to discuss linting in the repo.

@claydiffrient claydiffrient mentioned this pull request Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants