Trouble with basic install

[roygold]

Hello, I'm struggling with a basic react-rails install in a simple/vanilla app.

Short version:

After an attempted install, Loading any page results in the error:

"couldn't find file 'react'
  (in .../app/assets/javascripts/application.js:16)

coming from the second line of the extracted source below (from app/views/layouts/application.html.erb)

  <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track' => true %>
  <%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>

  <%= csrf_meta_tags %>
</head>

Also, if I try modifying config/environments/development.rb by adding

config.react.variant = :development

then as soon as I start the rails server I get an error (personal paths changed to ... below)

$ bin/rails s -b 0.0.0.0
=> Booting WEBrick
=> Rails 4.2.0 application starting in development on http://0.0.0.0:3000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Exiting
.../.rvm/gems/ruby-2.2.0/gems/railties-4.2.0/lib/rails/railtie/configuration.rb:95:in `method_missing': undefined method `react' for #<Rails::Application::Configuration:0x00000001a79d50> (NoMethodError)
    from .../config/environments/development.rb:42:in `block in <top (required)>'
    from .../.rvm/gems/ruby-2.2.0/gems/railties-4.2.0/lib/rails/railtie.rb:210:in `instance_eval'
    from .../.rvm/gems/ruby-2.2.0/gems/railties-4.2.0/lib/rails/railtie.rb:210:in `configure'
    from .../config/environments/development.rb:1:in `<top (required)>'
    from .../.rvm/gems/ruby-2.2.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:274:in `require'
...

I have hit this with both 1.0.0.pre and 0.12.0, with no noticeable change. Here are the instructions I believe I've followed: https://github.com/reactjs/react-rails/blob/master/README.md

Here's some info about what I'm running:

$ ruby -v
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux]
$ rails -v
Rails 4.2.0

This line is at the bottom of my Gemfile:

gem 'react-rails', '~> 1.0.0.pre', github: 'reactjs/react-rails'

And I ran "bundle install", and here's the relevant parts of the output:

Using react-source 0.12.2
Using react-rails 1.0.0.pre from git://github.com/reactjs/react-rails.git (at master)

I also ran

rails g react:install

Here's the relevant portion of app/assets/javascripts/application.js

...
// Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
// about supported directives.
//
//= require jquery
//= require jquery_ujs
//= require turbolinks
//= require react
//= require react_ujs
//= require components
//= require_tree .

The sample app works fine if I leave out the newly added "require" lines from application.js (or comment out javascript_include_tag line from app/views/layouts/application.html.erb).

Any suggestions would be very welcome; as I mentioned, I also tried 0.12 (based on the instructions here, and got the exact same results: https://github.com/reactjs/react-rails/blob/0.12/README.md )

Thanks!

[xionon]

I think spring has issues with gems installed directly from github

Try stopping and uninstalling spring and running your app again.

On Wed, Feb 25, 2015 at 10:39 AM, roygold notifications@github.com wrote:

Hello, I'm struggling with a basic react-rails install in a simple/vanilla
app.

Short version:

After an attempted install, Loading any page results in the error:

"couldn't find file 'react'
(in .../app/assets/javascripts/application.js:16)

coming from the second line of the extracted source below (from
app/views/layouts/application.html.erb)

<%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track' => true %>
<%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>

<%= csrf_meta_tags %>

Also, if I try modifying config/environments/development.rb by adding

config.react.variant = :development

then as soon as I start the rails server I get an error (personal paths
changed to ... below)

$ bin/rails s -b 0.0.0.0
=> Booting WEBrick
=> Rails 4.2.0 application starting in development on http://0.0.0.0:3000
=> Run rails server -h for more startup options
=> Ctrl-C to shutdown server
Exiting
.../.rvm/gems/ruby-2.2.0/gems/railties-4.2.0/lib/rails/railtie/configuration.rb:95:in method_missing': undefined methodreact' for #Rails::Application::Configuration:0x00000001a79d50 (NoMethodError)
from .../config/environments/development.rb:42:in block in <top (required)>' from .../.rvm/gems/ruby-2.2.0/gems/railties-4.2.0/lib/rails/railtie.rb:210:ininstance_eval'
from .../.rvm/gems/ruby-2.2.0/gems/railties-4.2.0/lib/rails/railtie.rb:210:in configure' from .../config/environments/development.rb:1:in<top (required)>'
from .../.rvm/gems/ruby-2.2.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:274:in `require'
...

I have hit this with both 1.0.0.pre and 0.12.0, with no noticeable change.
Here are the instructions I believe I've followed:
https://github.com/reactjs/react-rails/blob/master/README.md

Here's some info about what I'm running:

$ ruby -v
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux]
$ rails -v
Rails 4.2.0

This line is at the bottom of my Gemfile:

gem 'react-rails', '~> 1.0.0.pre', github: 'reactjs/react-rails'

And I ran "bundle install", and here's the relevant parts of the output:

Using react-source 0.12.2
Using react-rails 1.0.0.pre from git://github.com/reactjs/react-rails.git (at master)

I also ran

rails g react:install

Here's the relevant portion of app/assets/javascripts/application.js

...
// Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
// about supported directives.
//
//= require jquery
//= require jquery_ujs
//= require turbolinks
//= require react
//= require react_ujs
//= require components
//= require_tree .

The sample app works fine if I leave out the newly added "require" lines
from application.js (or comment out javascript_include_tag line from
app/views/layouts/application.html.erb).

Any suggestions would be very welcome; as I mentioned, I also tried 0.12
(based on the instructions here, and got the exact same results:
https://github.com/reactjs/react-rails/blob/0.12/README.md )

Thanks!

—
Reply to this email directly or view it on GitHub
#184.

[roygold]

Thanks for the reply, but that doesn't seem to make a difference. I stopped the server, did a "gem uninstall spring," also tried "bin/spring binstub --remove --all" per instructions here: https://github.com/rails/spring. Removed spring from Gemfile, reran bundle install... spring is no longer showing up in "gem list". Then re-ran the rails server, but same results. Note I had the same problem when trying react-rails 0.12 as a local gem.

[rmosolgo]

Humm, I think react-rails expects to find that js tmp/react-rails/react.js

which is inserted by an initializer that initializer might be giving other troubles too (#148, #175).

@roygold is that file present in your project?

[roygold]

There is no react-rails directory in tmp:

.../tmp$ ls
cache  pids  sessions  sockets

[rmosolgo]

huh, i wonder if it's running into a problem on that initializer or never running it at all 😞

[jtmalinowski]

Yeah, I think we need to take a stab at the initializer again

[vipulnsward]

I think we can go ahead with trying #187

[roygold]

Hi all, I'm curious if you have any theories as to why I'm seeing this but others aren't (or don't seem to? I couldn't find any other open issues about this exact problem)? This happens every time for me on what feels like the most vanilla of basic install/example. Theories on what I'm doing differently that others aren't? If it matters, I'm running this on Ubuntu under VirtualBox on a recent MacBook Pro (2.8 GHz Intel Core i5). Thanks.

[rmosolgo]

I think the problem is that these lines aren't accomplishing their purpose:

https://github.com/reactjs/react-rails/blob/master/lib/react/rails/railtie.rb#L47-L50

They're supposed to copy React-related javascript files into tmp/react-rails/, but like you said, that folder isn't there. So ... how could it be failing?

• It never runs the initializer at all?
• It runs, but fails (and doesnt raise an error)?
• It runs and succeeds, but then somehow that directory is removed?

Regarding that first possibility, you could try checking out my branch in #187 and see if that improves your case. It seems like, depending on what kind of app server you use in development (and which version of that server), the react-rails initializer behaves slightly differently 😖

Regarding the second possibility, there was some mention of file permissions issues getting in the way of the initializer (#175). Is there any chance of something along those lines in your setup?

As for the third possibility, I really don't expect that to happen!

[vipulnsward]

@roygold for now you can get away by defining config if any on application.rb

[vipulnsward]

btw @rmosolgo , the initializer is guaranteed to be run form rails, irrespective of not finding the after "sprockets" initializer hook.

@roygold can you create a sample vanilla app, as you said, which could demonstrate this issue.

[bensie]

Sitting here with @rmosolgo, I came up with a Rails 4.2.1 app that may demonstrate this issue. For me, the app works fine if I'm running from react-rails/master, but if I lock to a RubyGems version, I get the couldn't find file 'react' error you described.

https://github.com/bensie/react-rails-load-issue

Fails with https://github.com/bensie/react-rails-load-issue/blob/master/Gemfile#L26, but works if I change that line to gem 'react-rails', '~> 1.0.0.pre', github: 'reactjs/react-rails'.

Proposal: release master as 0.13.1.0 (aligns with current React version).

❤️ ❤️ ❤️

[rmosolgo]

I took a try with @bensie's app:

rmosolgo ~/code $ git clone git@github.com:bensie/react-rails-load-issue.git
Cloning into 'react-rails-load-issue'...
rmosolgo ~/code $ cd react-rails-load-issue/
rmosolgo ~/code/react-rails-load-issue $ bundle install
Fetching gem metadata from https://rubygems.org/.........
rmosolgo ~/code/react-rails-load-issue $ bundle exec rails server
=> Booting WEBrick
=> Rails 4.2.1 application starting in development on http://localhost:3000

I got the same thing:

Then I switched to:

gem 'react-rails', github: 'reactjs/react-rails'

And I got:

(actually I had to add <h1>It's working</h1>)

I like @bensie's suggestion to release master as 0.13.1 -- clearly good stuff has happened in master and if we leave that out of these other versions, sadness happens.

[zpao]

I wouldn't release master as 0.13.1 (that's confusing when 0.13.0 and the rest of the 0.x.y family don't have any of the good stuff in master). Just ship 1.0 and forget about versioning with React versions. Just upgrade the dependency purposefully and bump the react-rails version appropriately when you do.

[bensie]

Cool that makes sense too. Should the README be updated to encourage specifying a custom "react-source" line in the Gemfile? That way it's clear that react-rails != react and it should work on any version greater than whatever is in the gemspec.