Error with Rails 5 in production env

[renchap]

Rails 5 : rails/rails@472b8e0
react-rails : 290765a
Sprockets : rails/sprockets@c8b96cd

When deploying in the production env, I get this error :

NoMethodError: undefined method `[]' for nil:NilClass
File ".../bundle/ruby/2.2/bundler/gems/react-rails-290765a1ac14/lib/react/server_rendering/sprockets_renderer.rb" line 14 in block in initialize
File ".../bundle/ruby/2.2/bundler/gems/react-rails-290765a1ac14/lib/react/server_rendering/sprockets_renderer.rb" line 13 in each
File ".../bundle/ruby/2.2/bundler/gems/react-rails-290765a1ac14/lib/react/server_rendering/sprockets_renderer.rb" line 13 in initialize
File ".../bundle/ruby/2.2/bundler/gems/react-rails-290765a1ac14/lib/react/server_rendering.rb" line 22 in new
File ".../bundle/ruby/2.2/bundler/gems/react-rails-290765a1ac14/lib/react/server_rendering.rb" line 22 in create_renderer
File ".../bundle/ruby/2.2/bundler/gems/react-rails-290765a1ac14/lib/react/server_rendering.rb" line 12 in block in reset_pool

The error occurs here :

react-rails/lib/react/server_rendering/sprockets_renderer.rb

Line 14 in 290765a

js_code << ::Rails.application.assets[filename].to_s

After looking in the console, Rails.application.assets is empty in this environment. Setting config.assets.compile = true in config/environments/production.rb fixes the issue.

I dont really know how this can be fixed otherwise, this is my first try at react / react-rails.

[SylarRuby]

Are you using ruby 2.2.1+?

[renchap]

Yes, ruby 2.2.3p173

[SylarRuby]

Maybe a bug in react-rails. Others will comment.

[rmosolgo]

I think it's the same problem as #288, but now it totally 💥s instead of just being inefficient.

Sorry I haven't gotten a chance to fix it yet! Maybe this afternoon.

[acconrad]

Any progress on this? I'm seeing this issue on Rails 4.2.5 with Ruby 2.1.5 and Sprockets 3.5.2 (Sprockets-rails 3.0)

[losvedir]

This 💥 s for us when precompiling assets, even though we aren't using prerender: true anywhere. One solution if you don't need the server side rendering is to just configure a dummy renderer:

config.react.server_renderer = Class.new do
  def initialize(params = {})
  end

  def render(component_name, props, prerender_options)
    ''
  end
end

Can @rmosolgo comment if this would have any negative consequences I'm not thinking of if we're not using server side rendering?

[rmosolgo]

If you're not using server-side rendering, I can't imagine any negative consequences! That's a nice application of the null object pattern :)

Sorry I've been kicking the can on this, just installed the new Rails 5 beta to reproduce the issue locally!

[rmosolgo]

I reproduced the issue locally and "fixed" it with this patch: #430

Still a few things to do there but at least I can see the way forward :D

[losvedir]

Thanks!

[augnustin]

Any quick workaround for new comers?

[rmosolgo]

You could try: #443 (comment)

[rmosolgo]

I guess this is fixed on recent versions, please let me know if it isn't!!