Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.10.0.0 is broken #53

Closed
lencioni opened this issue Jun 16, 2014 · 3 comments
Closed

v0.10.0.0 is broken #53

lencioni opened this issue Jun 16, 2014 · 3 comments

Comments

@lencioni
Copy link
Contributor

The new version of the gem that was released today, v0.10.0.0, is broken. I believe that the wrong commit ended up being tagged. Instead of 9ed1c02, I think you want to tag 9a76532.

This may present itself as errors like Sprockets not being able to find react or the react_component view helper not existing.
@lencioni lencioni mentioned this issue Jun 16, 2014
Closed
@zpao
Copy link
Member

zpao commented Jun 16, 2014

Well, 0.10.0.0 was actually released 2 months ago. I did tag the right commit then. But 64b3061 did go in after and we should probably ship 0.10.0.1 with it.

The react_component helper doesn't exist in 0.10.* so I don't think that will be an issue :)

@zpao
Copy link
Member

zpao commented Jun 16, 2014

I definitely don't want to tag 9a76532 though, that's the merge back into master, which isn't ready for a release afaik.

@lencioni
Copy link
Contributor Author

Oh, lulz. I had weirdly assumed that the 0.10 branch coincided with v0.10.0.0 being released. Carry on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zpao @lencioni