Use Manifest#dir for sprockets 3 compatibility #478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changed in sprockets a while ago rails/sprockets@3255c8c But it's nice to support those using the ancient 3.X version.
|
This seems good! But now I'm trying to figure out ... how did this ever work!? |
|
Yeah, good question. I'm not sure. But somehow it broke for us when we updated from 1.5.0 to 1.6.0 |
|
I cherry-picked it to #453 to make sure it was good on all versions of Sprockets. And it looks like it is! So, it got merged to master along with that. Thanks for this fix! |
|
🚢 in 1.6.1, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changed in sprockets a while ago rails/sprockets@3255c8c
But it's nice to support those using the ancient 3.X version.