Skip to content

include module-related code when generating for webpack #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2017
Merged

include module-related code when generating for webpack #710

merged 1 commit into from
May 11, 2017

Conversation

rmosolgo
Copy link
Member

No description provided.

@rmosolgo rmosolgo mentioned this pull request May 11, 2017
Closed
4 tasks
@rmosolgo
Copy link
Member Author

Same Rails 5.1 failures

@rmosolgo rmosolgo merged commit 4c3482b into master May 11, 2017
@rmosolgo rmosolgo deleted the include-modules-in-genertated-components branch May 11, 2017 20:51
@ViXP
Copy link
Contributor

ViXP commented Jul 31, 2017

Please, fix the --coffee generator too

@rmosolgo
Copy link
Member Author

@ViXP if you've noticed a bug or if you have a feature request, please open an issue!

@ViXP
Copy link
Contributor

ViXP commented Aug 11, 2017 •
edited
Loading

--coffee generator must include this
"module.exports = @#{component_name}"
too
I fixed this issue in this pull request #768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmosolgo @ViXP