🐛 Use ReactDOM.render instead of hydrate when prerender is falsy #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow react-rails to use ReactDOM.render in components created whose value for prerender is falsy (false, nil).
|
This is excellent, thanks for the contribution! |
BookOfGreg
added a commit
that referenced
this pull request
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow react-rails to use ReactDOM.render in components created whose value for prerender is falsy (false, nil).
Summary
React gives a warning when a not pre-rendered component is not rendered using ReactDOM.render()
Following advise from #842
A new html option has been added to use between the ReactDOM methods render() or hydrate().
render()
prerender not set or set to a falsy value
hydrate()
truthy value and not :static