Update README.md: Webpacker 4.x supported #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@0xdevalias thanks for asking for clarity on this. Webpacker 4.x is supported in that it didn't crash the tests. I haven't personally tried it yet as my time is limited. |
|
We're currently not using react-rails, but just upgraded to webpacker 4, so when I have some spare time to investigate whether we can migrate to it, I'll let you know! |
|
Going to merge this just now. If you could open an issue or comment here to say once you've taken a look at it that would be appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After https://github.com/reactjs/react-rails/pull/934/files#diff-3bb7346aca79d8142e16e61372bd04dcR14 was merged, i'm guessing that means Webpacker 4.x is actually supported now? README didn't say it was though.
Related: