Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use history.createLocation where possible #2910

Merged
merged 1 commit into from
Feb 3, 2016
Merged

Use history.createLocation where possible #2910

merged 1 commit into from
Feb 3, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jan 15, 2016

Fixes #2859

The tests won't pass until remix-run/history#200 is merged and released.

@taion
Copy link
Contributor Author

taion commented Feb 3, 2016

Updated with bumped history dependency. Tests should pass now.

@timdorr
Copy link
Member

timdorr commented Feb 3, 2016

No idea why the build failed the first time around. Travis has been doing this on a lot of my JS projects lately....

timdorr added a commit that referenced this pull request Feb 3, 2016
Use history.createLocation where possible
@timdorr timdorr merged commit 9ace5fd into remix-run:master Feb 3, 2016
@taion taion deleted the use-history-createLocation branch February 3, 2016 20:05
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants