Skip to content

Conversation

evenstensberg
Copy link

Made it easier to navigate between documents.

@tcharlat
Copy link

tcharlat commented May 6, 2016

Just reading the commits, I wonder : shouldn't the link have relative url ? I noticed some absolute links to your fork.

example : 'https://github.com/ev1stensberg/react-router/blob/master/docs/guides/ConfirmingNavigation.md'

@evenstensberg
Copy link
Author

@Kallikrein thanks, been copy + pasting from my own repo, lol. I'll fix it in a jiffy!

@tcharlat
Copy link

tcharlat commented May 7, 2016

You still use absolute url, I patched a file in an example commit for you.

-[Next Section - Histories](https://github.com/reactjs/react-router/blob/master/docs/guides/Histories.md)
+[Next Section - Histories](/docs/guides/Histories.md)

@evenstensberg
Copy link
Author

Think that's a matter of preference, there's no big perf in leaving routes absolute. As well as some of the links are outside the current folder. I'll leave that for he review(if so)

@timdorr
Copy link
Member

timdorr commented May 7, 2016

These docs aren't in any particular order, so having "next" links doesn't really apply. I'd look into helping on @knowbody's docs repo, so we can keep that ball rolling and eventually get that moved back here.

@timdorr timdorr closed this May 7, 2016
@evenstensberg
Copy link
Author

FWIW- made each link redirected ( Next - Section ) according to the content overview.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants