Fixes to ContextSubscriber #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
force-pushed
the
fix-context-subscriber
branch
from
47d7f90 to
bd6b6a1
Compare
- Use separate context object - Use correct subscribe method
taion
force-pushed
the
fix-context-subscriber
branch
from
bd6b6a1 to
f78fd20
Compare
|
👏 👍 |
| this.unsubscribe = null | ||
| }, | ||
|
|
||
| handleContextUpdate(eventIndex) { |
There was a problem hiding this comment.
Just curious: Why the method extraction?
There was a problem hiding this comment.
No particular reason. Felt like I might as well take advantage of the autobinding in React.createClass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting this PR here ahead of pulling this out into a separate library just for the sake of visibility. This fixes a couple of my bugs in the original ContextSubscriber implementation. After this, I'll pull this out into a separate library.