Skip to content

[HOLD OFF ON MERGING] Deprecate routeParams #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HOLD OFF ON MERGING] Deprecate routeParams #3593

wants to merge 1 commit into from

Conversation

taion
Copy link
Contributor

@taion taion commented Jun 30, 2016

Closes #3549

@taion taion force-pushed the deprecate-routeParams branch from 1f56392 to 52db366 Compare June 30, 2016 17:24
@taion
Copy link
Contributor Author

taion commented Jun 30, 2016

Don't merge this until after we cut v2.5.2 with #3591.

This is ahead of dropping routeParams entirely in v3.

@timdorr
Copy link
Member

timdorr commented Jun 30, 2016

👍

@taion taion changed the title Deprecate routeParams [HOLD OFF ON MERGING] Deprecate routeParams Jul 1, 2016
@taion
Copy link
Contributor Author

taion commented Jul 1, 2016

Hold off on merging this for a bit. Want to think about it a little.

@taion
Copy link
Contributor Author

taion commented Aug 2, 2016

Again closing this for now since I don't think it should be merged as-is. Better to generate "real" routeParams per route, maybe, and expose those.

@taion taion closed this Aug 2, 2016
@taion taion deleted the deprecate-routeParams branch August 2, 2016 16:32
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @timdorr