Updates links to old docs in README #3650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| **Older Versions:** | ||
|
|
||
| - 0.13.x - [docs](https://github.com/reactjs/react-router/tree/0.13.x/doc) / [guides](https://github.com/reactjs/react-router/tree/0.13.x/docs/guides) / [code](https://github.com/reactjs/react-router/tree/0.13.x) / [upgrade guide](https://github.com/reactjs/react-router/blob/master/upgrade-guides/v1.0.0.md) | ||
| - 0.13.x - [docs](https://github.com/reactjs/react-router/tree/v0.13.6/doc) / [guides](https://github.com/reactjs/react-router/tree/v0.13.6/docs/guides) / [code](https://github.com/reactjs/react-router/tree/v0.13.6) / [upgrade guide](https://github.com/reactjs/react-router/blob/master/upgrade-guides/v1.0.1.md) |
There was a problem hiding this comment.
Fat-fingered that one. Will fix!
|
Thanks. |
|
I'll merge when CI goes green. |
|
I sorta wanna drop those links, actually. |
|
Curious: why is that? Assuming because 0.13.x has been deprecated for ~6 months at this point :D While they'll always be visible to those that dig through the old tags, I'd argue for having some sort of link in the Readme that points n00bs to the most recent 0.13.x tag. |
|
It's been 8 months since 1.0.0 and 10 since 1.0.0-rc1. |
|
I agree with dropping them. But let's give it until 3.0 final so folks can update their bookmarks. And we can just keep a rolling set of the 2 previous version branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was looking to point one of our designers to the 0.13.x docs only to find that the links were dead :( (As per #3607)
This is a small update to the README to make those links valid again. Happy to update any other legacy doc stuff as needed!
(Also, there were no code changes so I opted to not add anything to
changes.md. Happy to do otherwise)