Add an example on how to use the onEnter callback #3660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an example on how to use the onEnter callback to redirect a user to another page.
docs/API.md
Outdated
| `cb(err)` | ||
|
|
||
| ```js | ||
| const userIsInAnOrganisation = (nextState, replace, callback) => { |
There was a problem hiding this comment.
Sorry for the awful tiny nit, but I think we generally use AmE for docs, to the extent it matters. Maybe this could just be userIsInAnOrg?
|
Thanks! Left a couple quick notes. |
|
I've addressed your notes! I renamed "organisations" to "teams" to avoid any unnecessary contention in spelling. |
docs/API.md
Outdated
| }) | ||
| } | ||
|
|
||
| <Route path="/users/:userId/teams" onEnter={userIsInAnTeam} /> |
|
Sorry, a couple more notes. Thanks for updating the docs – this is a great help |
|
Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an example to the documentation on how to use the onEnter callback to redirect a user to another page.