feat(tabs): verify click tabNode using *[role=tab] #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing `react-tabs` with a custom `TabList` & `Tab` components can be currently done by using the corresponding `tabRole` static in custom components. This is neat. However, the check within `isTabNode()` relies on the tagName being an `LI` element, and this has some limitations for cases where the `tabList` markup isn't done using a `ul > li` structure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
react-tabswith customTabList+Tabcomponents can be currently done using the correspondingtabsRolestatic property, and this is neat. However, the check withinisTabNode()relies on the tagName being anLIelement, and this has some limitations for cases where a custom<TabList />component's markup does not match theul > listructure.