Skip to content

Conversation

danez
Copy link
Collaborator

@danez danez commented Aug 20, 2015

I was not sure if it was by intention, but inside the files there were a mix of tabs and spaces. I converted all of them to spaces.

\t => \s\s

@edvinerikson
Copy link

This looks great to me. Is there anything blocking this @mzabriskie?

@BBB
Copy link

BBB commented Oct 19, 2015

@danez It might be worth adding a .editorconfig file alongside this PR. http://editorconfig.org/

Something like this:

root = true

[*]
indent_style = space
indent_size = 2
trim_trailing_whitespace = true
end_of_line = lf
insert_final_newline = true

@timdorr
Copy link
Member

timdorr commented Oct 19, 2015

I agree. Probably don't want to turn this into a religious war, but having consistent things like indentation and line endings is important.

mzabriskie added a commit that referenced this pull request Oct 19, 2015
Replace all tabs with spaces
@mzabriskie mzabriskie merged commit bd1ef91 into reactjs:master Oct 19, 2015
@danez danez deleted the tab-to-space branch October 19, 2015 19:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants