Skip to content

Added a cancel option to tab change event handler #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added a cancel option to tab change event handler #73

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae8a58f
Add a cancel option to tab change event handler
Feb 10, 2016
f944daa
Add a cancel option to tab change event handler
Feb 10, 2016
bf7ddb9
Bug fix
Feb 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/components/Tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,18 @@ module.exports = React.createClass({
// Keep reference to last index for event handler
const last = this.state.selectedIndex;

// Update selected index
this.setState({ selectedIndex: index, focus: focus === true });
// Check wether change event handler cancels the tab change
let cancel = false;

// Call change event handler
if (typeof this.props.onSelect === 'function') {
this.props.onSelect(index, last);
cancel = (this.props.onSelect(index, last) === false);
}

if (!cancel) {
// Update selected index
this.setState({ selectedIndex: index, focus: focus === true });
}
},

getNextTab(index) {
Expand Down